Compilation results for an-test-coord1001.eqiad.wmnet: System changes detected

Catalog differences

Summary

Resources only in the new catalog

• File[/etc/presto/resource-groups.properties]
• Presto::Properties[resource-groups]

Resources only in the old catalog

• File[/etc/presto/selectors.json]

Resources modified

• File[/etc/presto/resource-groups.properties]

  Parameters differences:

  --- File[/etc/presto/resource-groups.properties].orig
  +++ File[/etc/presto/resource-groups.properties]
  
  +    mode  => 0444
  +    group => presto
  +    owner => presto
  

  Content differences:

  --- /etc/presto/resource-groups.properties.orig
  +++ /etc/presto/resource-groups.properties
  @@ -0,0 +1,4 @@
  +# NOTE: This file is managed by Puppet.
  +
  +resource-groups.config-file=/etc/presto/resource-groups.json
  +resource-groups.configuration-manager=file

• File[/etc/presto/config.properties]

  Content differences:

  --- /etc/presto/config.properties.orig
  +++ /etc/presto/config.properties
  @@ -25,6 +25,3 @@
   node-scheduler.include-coordinator=false
   node-scheduler.network-topology=legacy
   query.max-memory=2GB
  -resource-groups.config-file=/etc/presto/resource-groups.json
  -resource-groups.configuration-manager=file
  -resource-groups.selector-file=/etc/presto/selectors.json

• Service[presto-server]

  Parameters differences:

  --- Service[presto-server].orig
  +++ Service[presto-server]
  
  @@
  -    require => ['Presto::Properties[config]', 'Presto::Properties[node]', 'Presto::Properties[log]', 'File[/etc/presto/jvm.config]', 'File[/var/log/presto]', 'Rsyslog::Conf[presto-server]', 'Systemd::Override[presto-umask]', 'File[/etc/presto/resource-groups.json]', 'File[/etc/presto/selectors.json]']
  +    require => ['Presto::Properties[config]', 'Presto::Properties[node]', 'Presto::Properties[log]', 'File[/etc/presto/jvm.config]', 'File[/var/log/presto]', 'Rsyslog::Conf[presto-server]', 'Systemd::Override[presto-umask]', 'Presto::Properties[resource-groups]', 'File[/etc/presto/resource-groups.json]']
  

• File[/etc/presto/resource-groups.json]

  Content differences:

  --- /etc/presto/resource-groups.json.orig
  +++ /etc/presto/resource-groups.json
  @@ -30,5 +30,25 @@
           }
         ]
       }
  +  ],
  +  "selectors": [
  +    {
  +      "source": "superset_user",
  +      "group": "global.high_priority"
  +    },
  +    {
  +      "user": "growthbook_user",
  +      "group": "global.high_priority"
  +    },
  +    {
  +      "clientTags": [
  +        "heavy"
  +      ],
  +      "group": "global.heavy"
  +    },
  +    {
  +      "queryType": "SELECT",
  +      "group": "global.standard"
  +    }
     ]
   }

• Presto::Properties[config]

  Parameters differences:

  --- Presto::Properties[config].orig
  +++ Presto::Properties[config]
  
  @@
  -    properties => {'coordinator': True, 'node-scheduler.include-coordinator': False, 'http-server.http.port': 8280, 'jmx.rmiregistry.port': 8279, 'discovery.uri': 'https://analytics-test-presto.eqiad.wmnet:8281', 'experimental.spill-enabled': False, 'resource-groups.configuration-manager': 'file', 'resource-groups.config-file': '/etc/presto/resource-groups.json', 'resource-groups.selector-file': '/etc/presto/selectors.json', 'node-scheduler.network-topology': 'legacy', 'http-server.http.enabled': True, 'discovery-server.enabled': True, 'query.max-memory': '2GB', 'http-server.authentication.type': 'KERBEROS', 'http.server.authentication.krb5.service-name': 'presto', 'http.server.authentication.krb5.keytab': '/etc/security/keytabs/presto/presto.keytab', 'http.authentication.krb5.config': '/etc/krb5.conf', 'join-distribution-type': 'AUTOMATIC', 'http-server.https.keystore.path': '/etc/presto/ssl/server.p12', 'http-server.https.keystore.key': 'batman', 'internal-communication.https.required': True, 'internal-communication.https.keystore.path': '/etc/presto/ssl/server.p12', 'internal-communication.https.keystore.key': 'batman', 'internal-communication.https.trust-store-path': '/etc/ssl/certs/java/cacerts', 'internal-communication.https.trust-store-password': 'changeit', 'http-server.https.port': 8281, 'http-server.https.enabled': True, 'internal-communication.kerberos.enabled': True}
  +    properties => {'coordinator': True, 'node-scheduler.include-coordinator': False, 'http-server.http.port': 8280, 'jmx.rmiregistry.port': 8279, 'discovery.uri': 'https://analytics-test-presto.eqiad.wmnet:8281', 'experimental.spill-enabled': False, 'node-scheduler.network-topology': 'legacy', 'http-server.http.enabled': True, 'discovery-server.enabled': True, 'query.max-memory': '2GB', 'http-server.authentication.type': 'KERBEROS', 'http.server.authentication.krb5.service-name': 'presto', 'http.server.authentication.krb5.keytab': '/etc/security/keytabs/presto/presto.keytab', 'http.authentication.krb5.config': '/etc/krb5.conf', 'join-distribution-type': 'AUTOMATIC', 'http-server.https.keystore.path': '/etc/presto/ssl/server.p12', 'http-server.https.keystore.key': 'batman', 'internal-communication.https.required': True, 'internal-communication.https.keystore.path': '/etc/presto/ssl/server.p12', 'internal-communication.https.keystore.key': 'batman', 'internal-communication.https.trust-store-path': '/etc/ssl/certs/java/cacerts', 'internal-communication.https.trust-store-password': 'changeit', 'http-server.https.port': 8281, 'http-server.https.enabled': True, 'internal-communication.kerberos.enabled': True}
  

• File[/etc/presto/selectors.json]

  Parameters differences:

  --- File[/etc/presto/selectors.json].orig
  +++ File[/etc/presto/selectors.json]
  
  -    group => root
  -    owner => root
  

  Content differences:

  --- /etc/presto/selectors.json.orig
  +++ /etc/presto/selectors.json
  @@ -1,22 +0,0 @@
  -{
  -  "selectors": [
  -    {
  -      "source": "superset_user",
  -      "group": "global.high_priority"
  -    },
  -    {
  -      "user": "growthbook_user",
  -      "group": "global.high_priority"
  -    },
  -    {
  -      "clientTags": [
  -        "heavy"
  -      ],
  -      "group": "global.heavy"
  -    },
  -    {
  -      "queryType": "SELECT",
  -      "group": "global.standard"
  -    }
  -  ]
  -}

• Presto::Properties[resource-groups]

  Parameters differences:

  --- Presto::Properties[resource-groups].orig
  +++ Presto::Properties[resource-groups]
  
  +    properties            => {'resource-groups.configuration-manager': 'file', 'resource-groups.config-file': '/etc/presto/resource-groups.json'}
  +    may_contain_passwords => False
  +    group                 => presto
  +    owner                 => presto
  

Relevant files

• Production catalog
• Change catalog
• Production errors/warnings
• Change errors/warnings
• Core Diff
• Standard Diff