Compilation results for phab2002.codfw.wmnet: System changes detected

Catalog differences

Summary

Resources only in the old catalog

• File[/usr/local/sbin/sync-phabricator-repos]
• File[/usr/local/sbin/sync-phabricator-home-dirs]

Resources modified

• Systemd::Unit[rsync-phabricator-home-dirs.service]

  Parameters differences:

  --- Systemd::Unit[rsync-phabricator-home-dirs.service].orig
  +++ Systemd::Unit[rsync-phabricator-home-dirs.service]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Firewall::Service[rsyncd_access_srv-dumps]

  Parameters differences:

  --- Firewall::Service[rsyncd_access_srv-dumps].orig
  +++ Firewall::Service[rsyncd_access_srv-dumps]
  
  @@
  -    srange => ['phab1004.eqiad.wmnet', 'phab2002.codfw.wmnet', 'clouddumps1001.wikimedia.org', 'clouddumps1002.wikimedia.org']
  +    srange => ['phab1004.eqiad.wmnet', 'phab2003.codfw.wmnet', 'clouddumps1001.wikimedia.org', 'clouddumps1002.wikimedia.org']
  

• Class[Profile::Phabricator::Main]

  Parameters differences:

  --- Class[Profile::Phabricator::Main].orig
  +++ Class[Profile::Phabricator::Main]
  
  @@
  -    passive_server => phab2002.codfw.wmnet
  +    passive_server => phab2003.codfw.wmnet
  

• Rsync::Quickdatacopy[phabricator-repos]

  Parameters differences:

  --- Rsync::Quickdatacopy[phabricator-repos].orig
  +++ Rsync::Quickdatacopy[phabricator-repos]
  
  @@
  -    dest_host => phab2002.codfw.wmnet
  +    dest_host => phab2003.codfw.wmnet
  

• Class[Profile::Phabricator::Datasync]

  Parameters differences:

  --- Class[Profile::Phabricator::Datasync].orig
  +++ Class[Profile::Phabricator::Datasync]
  
  @@
  -    passive_server      => phab2002.codfw.wmnet
  +    passive_server      => phab2003.codfw.wmnet
  @@
  -    dumps_rsync_clients => ['phab1004.eqiad.wmnet', 'phab2002.codfw.wmnet', 'clouddumps1001.wikimedia.org', 'clouddumps1002.wikimedia.org']
  +    dumps_rsync_clients => ['phab1004.eqiad.wmnet', 'phab2003.codfw.wmnet', 'clouddumps1001.wikimedia.org', 'clouddumps1002.wikimedia.org']
  

• Systemd::Timer::Job[rsync-phabricator-home-dirs]

  Parameters differences:

  --- Systemd::Timer::Job[rsync-phabricator-home-dirs].orig
  +++ Systemd::Timer::Job[rsync-phabricator-home-dirs]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Systemd::Unit[rsync-phabricator-repos.service]

  Parameters differences:

  --- Systemd::Unit[rsync-phabricator-repos.service].orig
  +++ Systemd::Unit[rsync-phabricator-repos.service]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• File[/var/log/rsync-phabricator-home-dirs]

  Parameters differences:

  --- File[/var/log/rsync-phabricator-home-dirs].orig
  +++ File[/var/log/rsync-phabricator-home-dirs]
  
  @@
  -    ensure => directory
  +    ensure => absent
  

• File[/lib/systemd/system/rsync-phabricator-repos.timer]

  Parameters differences:

  --- File[/lib/systemd/system/rsync-phabricator-repos.timer].orig
  +++ File[/lib/systemd/system/rsync-phabricator-repos.timer]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Systemd::Timer[rsync-phabricator-home-dirs]

  Parameters differences:

  --- Systemd::Timer[rsync-phabricator-home-dirs].orig
  +++ Systemd::Timer[rsync-phabricator-home-dirs]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Rsync::Quickdatacopy[phabricator-home-dirs]

  Parameters differences:

  --- Rsync::Quickdatacopy[phabricator-home-dirs].orig
  +++ Rsync::Quickdatacopy[phabricator-home-dirs]
  
  @@
  -    dest_host => phab2002.codfw.wmnet
  +    dest_host => phab2003.codfw.wmnet
  

• Service[rsync-phabricator-repos.timer]

  Parameters differences:

  --- Service[rsync-phabricator-repos.timer].orig
  +++ Service[rsync-phabricator-repos.timer]
  
  +    before => ['Exec[systemd daemon-reload for rsync-phabricator-repos.timer (rsync-phabricator-repos.timer)]']
  @@
  -    enable => True
  +    enable => False
  @@
  -    ensure => running
  +    ensure => stopped
  

• Exec[systemd daemon-reload for rsync-phabricator-repos.timer (rsync-phabricator-repos.timer)]

  Parameters differences:

  --- Exec[systemd daemon-reload for rsync-phabricator-repos.timer (rsync-phabricator-repos.timer)].orig
  +++ Exec[systemd daemon-reload for rsync-phabricator-repos.timer (rsync-phabricator-repos.timer)]
  
  -    before => ['Service[rsync-phabricator-repos.timer]']
  

• Systemd::Service[rsync-phabricator-home-dirs]

  Parameters differences:

  --- Systemd::Service[rsync-phabricator-home-dirs].orig
  +++ Systemd::Service[rsync-phabricator-home-dirs]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Systemd::Unit[rsync-phabricator-home-dirs.timer]

  Parameters differences:

  --- Systemd::Unit[rsync-phabricator-home-dirs.timer].orig
  +++ Systemd::Unit[rsync-phabricator-home-dirs.timer]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• File[/etc/logrotate.d/rsync-phabricator-home-dirs]

  Parameters differences:

  --- File[/etc/logrotate.d/rsync-phabricator-home-dirs].orig
  +++ File[/etc/logrotate.d/rsync-phabricator-home-dirs]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• File[/lib/systemd/system/rsync-phabricator-home-dirs.service]

  Parameters differences:

  --- File[/lib/systemd/system/rsync-phabricator-home-dirs.service].orig
  +++ File[/lib/systemd/system/rsync-phabricator-home-dirs.service]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• File[/etc/rsyslog.d/40-rsync-phabricator-home-dirs.conf]

  Parameters differences:

  --- File[/etc/rsyslog.d/40-rsync-phabricator-home-dirs.conf].orig
  +++ File[/etc/rsyslog.d/40-rsync-phabricator-home-dirs.conf]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Service[rsync-phabricator-home-dirs.timer]

  Parameters differences:

  --- Service[rsync-phabricator-home-dirs.timer].orig
  +++ Service[rsync-phabricator-home-dirs.timer]
  
  +    before => ['Exec[systemd daemon-reload for rsync-phabricator-home-dirs.timer (rsync-phabricator-home-dirs.timer)]']
  @@
  -    enable => True
  +    enable => False
  @@
  -    ensure => running
  +    ensure => stopped
  

• Nftables::Service[rsyncd_access_srv-dumps]

  Parameters differences:

  --- Nftables::Service[rsyncd_access_srv-dumps].orig
  +++ Nftables::Service[rsyncd_access_srv-dumps]
  
  @@
  -    src_ips => ['10.192.27.6', '10.64.16.101', '208.80.154.142', '208.80.154.71', '2620:0:860:114:10:192:27:6', '2620:0:861:102:10:64:16:101', '2620:0:861:2:208:80:154:142', '2620:0:861:3:208:80:154:71']
  +    src_ips => ['10.192.27.12', '10.64.16.101', '208.80.154.142', '208.80.154.71', '2620:0:860:114:10:192:27:12', '2620:0:861:102:10:64:16:101', '2620:0:861:2:208:80:154:142', '2620:0:861:3:208:80:154:71']
  

• Rsync::Server::Module[srv-dumps]

  Parameters differences:

  --- Rsync::Server::Module[srv-dumps].orig
  +++ Rsync::Server::Module[srv-dumps]
  
  @@
  -    hosts_allow => ['phab1004.eqiad.wmnet', 'phab2002.codfw.wmnet', 'clouddumps1001.wikimedia.org', 'clouddumps1002.wikimedia.org']
  +    hosts_allow => ['phab1004.eqiad.wmnet', 'phab2003.codfw.wmnet', 'clouddumps1001.wikimedia.org', 'clouddumps1002.wikimedia.org']
  

• File[/lib/systemd/system/rsync-phabricator-home-dirs.timer]

  Parameters differences:

  --- File[/lib/systemd/system/rsync-phabricator-home-dirs.timer].orig
  +++ File[/lib/systemd/system/rsync-phabricator-home-dirs.timer]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Nftables::Service[ssh_cluster]

  Parameters differences:

  --- Nftables::Service[ssh_cluster].orig
  +++ Nftables::Service[ssh_cluster]
  
  @@
  -    src_ips => ['10.192.27.6', '10.64.16.101', '2620:0:860:114:10:192:27:6', '2620:0:861:102:10:64:16:101']
  +    src_ips => ['10.192.27.12', '10.64.16.101', '2620:0:860:114:10:192:27:12', '2620:0:861:102:10:64:16:101']
  

• Systemd::Timer::Job[rsync-phabricator-repos]

  Parameters differences:

  --- Systemd::Timer::Job[rsync-phabricator-repos].orig
  +++ Systemd::Timer::Job[rsync-phabricator-repos]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Firewall::Service[ssh_cluster]

  Parameters differences:

  --- Firewall::Service[ssh_cluster].orig
  +++ Firewall::Service[ssh_cluster]
  
  @@
  -    srange => ['phab1004.eqiad.wmnet', 'phab2002.codfw.wmnet']
  +    srange => ['phab1004.eqiad.wmnet', 'phab2003.codfw.wmnet']
  

• Systemd::Service[rsync-phabricator-repos]

  Parameters differences:

  --- Systemd::Service[rsync-phabricator-repos].orig
  +++ Systemd::Service[rsync-phabricator-repos]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Ferm::Service[ssh_cluster]

  Parameters differences:

  --- Ferm::Service[ssh_cluster].orig
  +++ Ferm::Service[ssh_cluster]
  
  @@
  -    srange => ['phab1004.eqiad.wmnet', 'phab2002.codfw.wmnet']
  +    srange => ['phab1004.eqiad.wmnet', 'phab2003.codfw.wmnet']
  

• Exec[systemd daemon-reload for rsync-phabricator-home-dirs.timer (rsync-phabricator-home-dirs.timer)]

  Parameters differences:

  --- Exec[systemd daemon-reload for rsync-phabricator-home-dirs.timer (rsync-phabricator-home-dirs.timer)].orig
  +++ Exec[systemd daemon-reload for rsync-phabricator-home-dirs.timer (rsync-phabricator-home-dirs.timer)]
  
  -    before => ['Service[rsync-phabricator-home-dirs.timer]']
  

• Rsyslog::Conf[rsync-phabricator-repos]

  Parameters differences:

  --- Rsyslog::Conf[rsync-phabricator-repos].orig
  +++ Rsyslog::Conf[rsync-phabricator-repos]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Systemd::Timer[rsync-phabricator-repos]

  Parameters differences:

  --- Systemd::Timer[rsync-phabricator-repos].orig
  +++ Systemd::Timer[rsync-phabricator-repos]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• File[/etc/rsyslog.d/40-rsync-phabricator-repos.conf]

  Parameters differences:

  --- File[/etc/rsyslog.d/40-rsync-phabricator-repos.conf].orig
  +++ File[/etc/rsyslog.d/40-rsync-phabricator-repos.conf]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Concat_fragment[/etc/rsyncd.conf-srv-dumps]

  Content differences:

  --- /etc/rsyncd.conf-srv-dumps.orig
  +++ /etc/rsyncd.conf-srv-dumps
  @@ -16,5 +16,5 @@
   
   
   
  -hosts allow = phab1004.eqiad.wmnet phab2002.codfw.wmnet clouddumps1001.wikimedia.org clouddumps1002.wikimedia.org localhost
  +hosts allow = phab1004.eqiad.wmnet phab2003.codfw.wmnet clouddumps1001.wikimedia.org clouddumps1002.wikimedia.org localhost
   

• Systemd::Syslog[rsync-phabricator-home-dirs]

  Parameters differences:

  --- Systemd::Syslog[rsync-phabricator-home-dirs].orig
  +++ Systemd::Syslog[rsync-phabricator-home-dirs]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Systemd::Syslog[rsync-phabricator-repos]

  Parameters differences:

  --- Systemd::Syslog[rsync-phabricator-repos].orig
  +++ Systemd::Syslog[rsync-phabricator-repos]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Rsyslog::Conf[rsync-phabricator-home-dirs]

  Parameters differences:

  --- Rsyslog::Conf[rsync-phabricator-home-dirs].orig
  +++ Rsyslog::Conf[rsync-phabricator-home-dirs]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Logrotate::Conf[rsync-phabricator-repos]

  Parameters differences:

  --- Logrotate::Conf[rsync-phabricator-repos].orig
  +++ Logrotate::Conf[rsync-phabricator-repos]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• File[/etc/logrotate.d/rsync-phabricator-repos]

  Parameters differences:

  --- File[/etc/logrotate.d/rsync-phabricator-repos].orig
  +++ File[/etc/logrotate.d/rsync-phabricator-repos]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Ferm::Service[rsyncd_access_srv_dumps]

  Parameters differences:

  --- Ferm::Service[rsyncd_access_srv_dumps].orig
  +++ Ferm::Service[rsyncd_access_srv_dumps]
  
  @@
  -    srange => ['phab1004.eqiad.wmnet', 'phab2002.codfw.wmnet', 'clouddumps1001.wikimedia.org', 'clouddumps1002.wikimedia.org']
  +    srange => ['phab1004.eqiad.wmnet', 'phab2003.codfw.wmnet', 'clouddumps1001.wikimedia.org', 'clouddumps1002.wikimedia.org']
  

• Systemd::Unit[rsync-phabricator-repos.timer]

  Parameters differences:

  --- Systemd::Unit[rsync-phabricator-repos.timer].orig
  +++ Systemd::Unit[rsync-phabricator-repos.timer]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• File[/etc/nftables/input/10_rsyncd_access_srv-dumps.nft]

  Content differences:

  --- /etc/nftables/input/10_rsyncd_access_srv-dumps.nft.orig
  +++ /etc/nftables/input/10_rsyncd_access_srv-dumps.nft
  @@ -1,4 +1,4 @@
   # Managed by puppet
   # 
  -ip saddr { 10.192.27.6, 10.64.16.101, 208.80.154.142, 208.80.154.71 } tcp dport { 873, 1873 } accept
  -ip6 saddr { 2620:0:860:114:10:192:27:6, 2620:0:861:102:10:64:16:101, 2620:0:861:2:208:80:154:142, 2620:0:861:3:208:80:154:71 } tcp dport { 873, 1873 } accept
  +ip saddr { 10.192.27.12, 10.64.16.101, 208.80.154.142, 208.80.154.71 } tcp dport { 873, 1873 } accept
  +ip6 saddr { 2620:0:860:114:10:192:27:12, 2620:0:861:102:10:64:16:101, 2620:0:861:2:208:80:154:142, 2620:0:861:3:208:80:154:71 } tcp dport { 873, 1873 } accept

• File[/lib/systemd/system/rsync-phabricator-repos.service]

  Parameters differences:

  --- File[/lib/systemd/system/rsync-phabricator-repos.service].orig
  +++ File[/lib/systemd/system/rsync-phabricator-repos.service]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• Concat::Fragment[/etc/rsyncd.conf-srv-dumps]

• File[/var/log/rsync-phabricator-repos]

  Parameters differences:

  --- File[/var/log/rsync-phabricator-repos].orig
  +++ File[/var/log/rsync-phabricator-repos]
  
  @@
  -    ensure => directory
  +    ensure => absent
  

• Logrotate::Conf[rsync-phabricator-home-dirs]

  Parameters differences:

  --- Logrotate::Conf[rsync-phabricator-home-dirs].orig
  +++ Logrotate::Conf[rsync-phabricator-home-dirs]
  
  @@
  -    ensure => present
  +    ensure => absent
  

• File[/etc/nftables/input/10_ssh_cluster.nft]

  Content differences:

  --- /etc/nftables/input/10_ssh_cluster.nft.orig
  +++ /etc/nftables/input/10_ssh_cluster.nft
  @@ -1,4 +1,4 @@
   # Managed by puppet
   # 
  -ip saddr { 10.192.27.6, 10.64.16.101 } tcp dport { 22 } accept
  -ip6 saddr { 2620:0:860:114:10:192:27:6, 2620:0:861:102:10:64:16:101 } tcp dport { 22 } accept
  +ip saddr { 10.192.27.12, 10.64.16.101 } tcp dport { 22 } accept
  +ip6 saddr { 2620:0:860:114:10:192:27:12, 2620:0:861:102:10:64:16:101 } tcp dport { 22 } accept

Relevant files

• Production catalog
• Change catalog
• Production errors/warnings
• Change errors/warnings
• Core Diff
• Full Diff