Compilation results for cloudcontrol2005-dev.codfw.wmnet: System changes detected

Catalog differences

Summary

Resources only in the new catalog

• Class[Java]
• File[/etc/zookeeper/conf/myid]
• File[/lib/systemd/system/zookeeper-cleanup.service]
• Class[Zookeeper]
• Java::Package[openjdk-jdk-21]
• Class[Zookeeper::Server]
• File[/etc/default/zookeeper]
• Prometheus::Jmx_exporter_instance[zookeeper_server_cloudcontrol2005-dev]
• File[/etc/ferm/conf.d/10_zookeeper]
• Package[prometheus-jmx-exporter]
• Class[Profile::Zookeeper::Monitoring::Server]
• Exec[java__cacert_wmf:Wikimedia_Internal_Root_CA]
• Exec[systemd daemon-reload for zookeeper-cleanup.timer (zookeeper-cleanup.timer)]
• Service[zookeeper-cleanup.timer]
• File[/var/lib/zookeeper]
• Class[Profile::Java]
• Systemd::Timer[zookeeper-cleanup]
• Firewall::Service[zookeeper]
• File[/etc/prometheus]
• Systemd::Timer::Job[zookeeper-cleanup]
• Logrotate::Conf[zookeeper-cleanup]
• Systemd::Syslog[zookeeper-cleanup]
• File[/var/log/zookeeper-cleanup]
• Systemd::Service[zookeeper-cleanup]
• Alternatives::Java[21]
• File[/etc/zookeeper/conf/zoo.cfg]
• Package[zookeeperd]
• Exec[java__cacert_wmf:puppetca.pem]
• File[/lib/systemd/system/zookeeper-cleanup.timer]
• Systemd::Unit[zookeeper-cleanup.service]
• Class[Profile::Zookeeper::Server]
• File[/etc/logrotate.d/zookeeper-cleanup]
• Exec[systemd daemon-reload for zookeeper-cleanup.service (zookeeper-cleanup.service)]
• File[/etc/rsyslog.d/40-zookeeper-cleanup.conf]
• Service[zookeeper]
• Rsyslog::Conf[zookeeper-cleanup]
• Exec[update_java_alternatives_21]
• Profile::Prometheus::Jmx_exporter[zookeeper_server_cloudcontrol2005-dev]
• Systemd::Unit[zookeeper-cleanup.timer]
• File[/etc/prometheus/jvm_zookeeper_jmx_exporter.yaml]
• Java::Cacert[wmf:Wikimedia_Internal_Root_CA]
• File[/etc/zookeeper/conf/log4j.properties]
• Package[zookeeper]
• Class[Profile::Zookeeper::Firewall]
• Package[openjdk-21-jdk]
• File[/var/lib/zookeeper/myid]
• Ferm::Service[zookeeper]
• Java::Cacert[wmf:puppetca.pem]

Resources modified

• Systemd::Timer::Job[zookeeper-cleanup]

  Parameters differences:

  --- Systemd::Timer::Job[zookeeper-cleanup].orig
  +++ Systemd::Timer::Job[zookeeper-cleanup]
  
  +    fixed_random_delay        => False
  +    logfile_perms             => all
  +    success_exit_status       => []
  +    interval                  => {'start': 'OnCalendar', 'interval': '*-*-* 0:10:00'}
  +    send_mail_to              => root@cloudcontrol2005-dev.codfw.wmnet
  +    logging_enabled           => True
  +    private_tmp               => False
  +    monitoring_contact_groups => admins
  +    logfile_name              => syslog.log
  +    logfile_basedir           => /var/log
  +    monitoring_enabled        => False
  +    monitoring_notes_url      => https://wikitech.wikimedia.org/wiki/Monitoring/systemd_unit_state
  +    command                   => /usr/share/zookeeper/bin/zkCleanup.sh -n 10
  +    description               => Regular jobs for running the cleanup script
  +    syslog_force_stop         => True
  +    require                   => Service[zookeeper]
  +    send_mail                 => False
  +    send_mail_only_on_error   => True
  +    ensure                    => present
  +    syslog_match_startswith   => True
  +    logfile_group             => root
  +    environment               => {}
  +    ignore_errors             => False
  +    user                      => zookeeper
  

• File[/etc/prometheus/jvm_zookeeper_jmx_exporter.yaml]

  Parameters differences:

  --- File[/etc/prometheus/jvm_zookeeper_jmx_exporter.yaml].orig
  +++ File[/etc/prometheus/jvm_zookeeper_jmx_exporter.yaml]
  
  +    links  => follow
  +    owner  => root
  +    source => puppet:///modules/profile/zookeeper/jvm_prometheus_jmx_exporter.yaml
  +    ensure => present
  +    group  => root
  +    mode   => 0444
  

• Package[openjdk-21-jdk]

  Parameters differences:

  --- Package[openjdk-21-jdk].orig
  +++ Package[openjdk-21-jdk]
  
  +    ensure   => installed
  +    provider => apt
  

• File[/var/lib/zookeeper/myid]

  Parameters differences:

  --- File[/var/lib/zookeeper/myid].orig
  +++ File[/var/lib/zookeeper/myid]
  
  +    ensure => link
  +    group  => root
  +    owner  => root
  +    target => /etc/zookeeper/conf/myid
  

• Class[Profile::Apt]

  Parameters differences:

  --- Class[Profile::Apt].orig
  +++ Class[Profile::Apt]
  
  @@
  -    before => ['Package[puppet]', 'Package[facter]', 'Package[augeas-tools]', 'Package[virt-what]', 'Package[puppet-module-puppetlabs-augeas-core]', 'Package[python3-prometheus-client]', 'Package[python3-yaml]', 'Package[ruby-net-ssh]', 'Package[openssl]', 'Package[ssl-cert]', 'Package[ca-certificates]', 'Package[wmf-certificates]', 'Package[ntp]', 'Package[systemd-timesyncd]', 'Package[exim4-config]', 'Package[exim4-daemon-light]', 'Package[logrotate]', 'Package[prometheus-node-exporter]', 'Package[bsdutils]', 'Package[smartmontools]', 'Package[rsyslog]', 'Package[rsyslog-openssl]', 'Package[cadvisor]', 'Package[acct]', 'Package[byobu]', 'Package[colordiff]', 'Package[curl]', 'Package[debian-goodies]', 'Package[ethtool]', 'Package[gdb]', 'Package[gdisk]', 'Package[git]', 'Package[htop]', 'Package[httpry]', 'Package[iotop]', 'Package[iperf]', 'Package[jq]', 'Package[libtemplate-perl]', 'Package[lldpd]', 'Package[lshw]', 'Package[molly-guard]', 'Package[moreutils]', 'Package[net-tools]', 'Package[numactl]', 'Package[ncdu]', 'Package[ngrep]', 'Package[pigz]', 'Package[psmisc]', 'Package[pv]', 'Package[python3]', 'Package[screen]', 'Package[strace]', 'Package[sysstat]', 'Package[tcpdump]', 'Package[tmux]', 'Package[tree]', 'Package[vim]', 'Package[vim-addon-manager]', 'Package[vim-scripts]', 'Package[wipe]', 'Package[xfsprogs]', 'Package[zsh]', 'Package[icdiff]', 'Package[linux-perf]', 'Package[bsd-mailx]', 'Package[ack]', 'Package[netcat-openbsd]', 'Package[tshark]', 'Package[fzf]', 'Package[ripgrep]', 'Package[fd-find]', 'Package[kitty-terminfo]', 'Package[mtr-tiny]', 'Package[bat]', 'Package[efibootmgr]', 'Package[bind9-dnsutils]', 'Package[tzdata]', 'Package[python3-wmflib]', 'Package[starship]', 'Package[ruby-sorted-set]', 'Package[btop]', 'Package[linux-sysctl-defaults]', 'Package[apport]', 'Package[command-not-found]', 'Package[command-not-found-data]', 'Package[ecryptfs-utils]', 'Package[mlocate]', 'Package[os-prober]', 'Package[python3-apport]', 'Package[wpasupplicant]', 'Package[atop]', 'Package[apt-listchanges]', 'Package[isc-dhcp-client]', 'Package[rasdaemon]', 'Package[openssh-client]', 'Package[openssh-server]', 'Package[debdeploy-client]', 'Package[python3-dateutil]', 'Package[sudo]', 'Package[golang-cfssl]', 'Package[debmonitor-client]', 'Package[perccli]', 'Package[nagios-nrpe-server]', 'Package[monitoring-plugins]', 'Package[monitoring-plugins-basic]', 'Package[monitoring-plugins-standard]', 'Package[liburiparser1]', 'Package[python3-attr]', 'Package[iucode-tool]', 'Package[freeipmi-tools]', 'Package[freeipmi-ipmiseld]', 'Package[rsyslog-kafka]', 'Package[emacs-nox]', 'Package[prometheus-ipmi-exporter]', 'Package[libnet-dns-perl]', 'Package[iptables]', 'Package[ferm]', 'Package[ulogd2]', 'Package[conntrack]', 'Package[libapache2-mod-auth-openidc]', 'Package[apache2]', 'Package[links]', 'Package[keystone]', 'Package[alembic]', 'Package[ldapvi]', 'Package[python3-ldappool]', 'Package[python3-ldap3]', 'Package[ruby-net-ldap]', 'Package[python3-mwclient]', 'Package[libvirt-clients]', 'Package[python3-pytest]', 'Package[glance]', 'Package[placement-api]', 'Package[cinder-api]', 'Package[cinder-scheduler]', 'Package[cinder-volume]', 'Package[tgt]', 'Package[python3-trove]', 'Package[trove-common]', 'Package[trove-api]', 'Package[trove-taskmanager]', 'Package[trove-conductor]', 'Package[python3-sqlalchemy]', 'Package[designate-sink]', 'Package[designate-common]', 'Package[designate-mdns]', 'Package[designate]', 'Package[designate-api]', 'Package[designate-doc]', 'Package[designate-central]', 'Package[python3-git]', 'Package[mcrouter]', 'Package[radosgw]', 'Package[ceph-common]', 'Package[fio]', 'Package[heat-api]', 'Package[heat-api-cfn]', 'Package[heat-engine]', 'Package[magnum-api]', 'Package[magnum-conductor]', 'Package[python3-magnum-capi-helm]', 'Package[helm3]', 'Package[unzip]', 'Package[bridge-utils]', 'Package[nova-common]', 'Package[nova-conductor]', 'Package[nova-scheduler]', 'Package[nova-api]', 'Package[neutron-common]', 'Package[python3-novaclient]', 'Package[python3-glanceclient]', 'Package[python3-keystoneauth1]', 'Package[python3-keystoneclient]', 'Package[python3-openstackclient]', 'Package[python3-troveclient]', 'Package[python3-designateclient]', 'Package[python3-neutronclient]', 'Package[python3-osc-placement]', 'Package[python3-tenacity]', 'Package[patch]', 'Package[neutron-api]', 'Package[neutron-server]', 'Package[octavia-api]', 'Package[octavia-health-manager]', 'Package[octavia-housekeeping]', 'Package[octavia-worker]', 'Package[python3-octavia]', 'Package[python3-octaviaclient]', 'Package[ldap-utils]', 'Package[memcached]', 'Package[liburi-perl]', 'Package[mariadb-server]', 'Package[mariadb-backup]', 'Package[galera-4]', 'Package[barbican-api]', 'Package[ruby-concurrent]', 'Package[ruby]', 'Package[libruby]', 'Package[puppet-agent]', 'Package[prometheus-rsyslog-exporter]', 'Package[initramfs-tools]', 'Package[python3-click]', 'Package[python3-box]', 'Package[confd]', 'Package[python3-toml]', 'Package[vlan]', 'Package[prometheus-openstack-exporter]', 'Package[rsync]', 'Package[prometheus-memcached-exporter]', 'Package[tofu]', 'Package[prometheus-mysqld-exporter]', 'Package[bacula-fd]', 'Package[bacula-common]']
  +    before => ['Package[puppet]', 'Package[facter]', 'Package[augeas-tools]', 'Package[virt-what]', 'Package[puppet-module-puppetlabs-augeas-core]', 'Package[python3-prometheus-client]', 'Package[python3-yaml]', 'Package[ruby-net-ssh]', 'Package[openssl]', 'Package[ssl-cert]', 'Package[ca-certificates]', 'Package[wmf-certificates]', 'Package[ntp]', 'Package[systemd-timesyncd]', 'Package[exim4-config]', 'Package[exim4-daemon-light]', 'Package[logrotate]', 'Package[prometheus-node-exporter]', 'Package[bsdutils]', 'Package[smartmontools]', 'Package[rsyslog]', 'Package[rsyslog-openssl]', 'Package[cadvisor]', 'Package[acct]', 'Package[byobu]', 'Package[colordiff]', 'Package[curl]', 'Package[debian-goodies]', 'Package[ethtool]', 'Package[gdb]', 'Package[gdisk]', 'Package[git]', 'Package[htop]', 'Package[httpry]', 'Package[iotop]', 'Package[iperf]', 'Package[jq]', 'Package[libtemplate-perl]', 'Package[lldpd]', 'Package[lshw]', 'Package[molly-guard]', 'Package[moreutils]', 'Package[net-tools]', 'Package[numactl]', 'Package[ncdu]', 'Package[ngrep]', 'Package[pigz]', 'Package[psmisc]', 'Package[pv]', 'Package[python3]', 'Package[screen]', 'Package[strace]', 'Package[sysstat]', 'Package[tcpdump]', 'Package[tmux]', 'Package[tree]', 'Package[vim]', 'Package[vim-addon-manager]', 'Package[vim-scripts]', 'Package[wipe]', 'Package[xfsprogs]', 'Package[zsh]', 'Package[icdiff]', 'Package[linux-perf]', 'Package[bsd-mailx]', 'Package[ack]', 'Package[netcat-openbsd]', 'Package[tshark]', 'Package[fzf]', 'Package[ripgrep]', 'Package[fd-find]', 'Package[kitty-terminfo]', 'Package[mtr-tiny]', 'Package[bat]', 'Package[efibootmgr]', 'Package[bind9-dnsutils]', 'Package[tzdata]', 'Package[python3-wmflib]', 'Package[starship]', 'Package[ruby-sorted-set]', 'Package[btop]', 'Package[linux-sysctl-defaults]', 'Package[apport]', 'Package[command-not-found]', 'Package[command-not-found-data]', 'Package[ecryptfs-utils]', 'Package[mlocate]', 'Package[os-prober]', 'Package[python3-apport]', 'Package[wpasupplicant]', 'Package[atop]', 'Package[apt-listchanges]', 'Package[isc-dhcp-client]', 'Package[rasdaemon]', 'Package[openssh-client]', 'Package[openssh-server]', 'Package[debdeploy-client]', 'Package[python3-dateutil]', 'Package[sudo]', 'Package[golang-cfssl]', 'Package[debmonitor-client]', 'Package[perccli]', 'Package[nagios-nrpe-server]', 'Package[monitoring-plugins]', 'Package[monitoring-plugins-basic]', 'Package[monitoring-plugins-standard]', 'Package[liburiparser1]', 'Package[python3-attr]', 'Package[iucode-tool]', 'Package[freeipmi-tools]', 'Package[freeipmi-ipmiseld]', 'Package[rsyslog-kafka]', 'Package[emacs-nox]', 'Package[prometheus-ipmi-exporter]', 'Package[libnet-dns-perl]', 'Package[iptables]', 'Package[ferm]', 'Package[ulogd2]', 'Package[conntrack]', 'Package[libapache2-mod-auth-openidc]', 'Package[apache2]', 'Package[links]', 'Package[keystone]', 'Package[alembic]', 'Package[ldapvi]', 'Package[python3-ldappool]', 'Package[python3-ldap3]', 'Package[ruby-net-ldap]', 'Package[python3-mwclient]', 'Package[libvirt-clients]', 'Package[python3-pytest]', 'Package[glance]', 'Package[placement-api]', 'Package[cinder-api]', 'Package[cinder-scheduler]', 'Package[cinder-volume]', 'Package[tgt]', 'Package[python3-trove]', 'Package[trove-common]', 'Package[trove-api]', 'Package[trove-taskmanager]', 'Package[trove-conductor]', 'Package[python3-sqlalchemy]', 'Package[designate-sink]', 'Package[designate-common]', 'Package[designate-mdns]', 'Package[designate]', 'Package[designate-api]', 'Package[designate-doc]', 'Package[designate-central]', 'Package[python3-git]', 'Package[mcrouter]', 'Package[zookeeper]', 'Package[zookeeperd]', 'Package[radosgw]', 'Package[ceph-common]', 'Package[fio]', 'Package[heat-api]', 'Package[heat-api-cfn]', 'Package[heat-engine]', 'Package[magnum-api]', 'Package[magnum-conductor]', 'Package[python3-magnum-capi-helm]', 'Package[helm3]', 'Package[unzip]', 'Package[bridge-utils]', 'Package[nova-common]', 'Package[nova-conductor]', 'Package[nova-scheduler]', 'Package[nova-api]', 'Package[neutron-common]', 'Package[python3-novaclient]', 'Package[python3-glanceclient]', 'Package[python3-keystoneauth1]', 'Package[python3-keystoneclient]', 'Package[python3-openstackclient]', 'Package[python3-troveclient]', 'Package[python3-designateclient]', 'Package[python3-neutronclient]', 'Package[python3-osc-placement]', 'Package[python3-tenacity]', 'Package[patch]', 'Package[neutron-api]', 'Package[neutron-server]', 'Package[octavia-api]', 'Package[octavia-health-manager]', 'Package[octavia-housekeeping]', 'Package[octavia-worker]', 'Package[python3-octavia]', 'Package[python3-octaviaclient]', 'Package[ldap-utils]', 'Package[memcached]', 'Package[liburi-perl]', 'Package[mariadb-server]', 'Package[mariadb-backup]', 'Package[galera-4]', 'Package[barbican-api]', 'Package[ruby-concurrent]', 'Package[ruby]', 'Package[libruby]', 'Package[puppet-agent]', 'Package[prometheus-rsyslog-exporter]', 'Package[initramfs-tools]', 'Package[python3-click]', 'Package[python3-box]', 'Package[confd]', 'Package[python3-toml]', 'Package[vlan]', 'Package[prometheus-openstack-exporter]', 'Package[rsync]', 'Package[prometheus-jmx-exporter]', 'Package[openjdk-21-jdk]', 'Package[prometheus-memcached-exporter]', 'Package[tofu]', 'Package[prometheus-mysqld-exporter]', 'Package[bacula-fd]', 'Package[bacula-common]']
  

• Rsyslog::Conf[zookeeper-cleanup]

  Parameters differences:

  --- Rsyslog::Conf[zookeeper-cleanup].orig
  +++ Rsyslog::Conf[zookeeper-cleanup]
  
  +    ensure   => present
  +    priority => 40
  +    require  => File[/var/log/zookeeper-cleanup]
  +    mode     => 0444
  

• File[/etc/default/zookeeper]

  Parameters differences:

  --- File[/etc/default/zookeeper].orig
  +++ File[/etc/default/zookeeper]
  
  +    group   => root
  +    require => Package[zookeeperd]
  +    owner   => root
  

  Content differences:

  --- /etc/default/zookeeper.orig
  +++ /etc/default/zookeeper
  @@ -0,0 +1,6 @@
  +# Note: This file is managed by Puppet.
  +
  +# Enable JMX connections on port 9998
  +JMXLOCALONLY=false
  +JAVA_OPTS="-Xms1g -Xmx1g -javaagent:/usr/share/java/prometheus/jmx_prometheus_javaagent.jar=10.192.20.24:12181:/etc/prometheus/jvm_zookeeper_jmx_exporter.yaml -Dcom.sun.management.jmxremote.port=9998 -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false"
  +JAVA=/usr/lib/jvm/java-21-openjdk-amd64/bin/java

• Exec[java__cacert_wmf:Wikimedia_Internal_Root_CA]

  Parameters differences:

  --- Exec[java__cacert_wmf:Wikimedia_Internal_Root_CA].orig
  +++ Exec[java__cacert_wmf:Wikimedia_Internal_Root_CA]
  
  +    group   => root
  +    command => /usr/bin/keytool -import -trustcacerts -noprompt -cacerts     -file /usr/share/ca-certificates/wikimedia/Wikimedia_Internal_Root_CA.crt -storepass changeit -alias wmf:Wikimedia_Internal_Root_CA
  
  +    user    => root
  +    unless  => /usr/bin/keytool -list -cacerts -noprompt -storepass changeit -alias wmf:Wikimedia_Internal_Root_CA
  

• Profile::Prometheus::Jmx_exporter[zookeeper_server_cloudcontrol2005-dev]

  Parameters differences:

  --- Profile::Prometheus::Jmx_exporter[zookeeper_server_cloudcontrol2005-dev].orig
  +++ Profile::Prometheus::Jmx_exporter[zookeeper_server_cloudcontrol2005-dev]
  
  +    config_dir               => /etc/prometheus
  +    hostname                 => cloudcontrol2005-dev
  +    source                   => puppet:///modules/profile/zookeeper/jvm_prometheus_jmx_exporter.yaml
  +    port                     => 12181
  +    config_file              => /etc/prometheus/jvm_zookeeper_jmx_exporter.yaml
  +    extra_ferm_allowed_nodes => []
  +    labels                   => {'zookeeper_cluster': 'designate_eqiad1'}
  

• Service[zookeeper-cleanup.timer]

  Parameters differences:

  --- Service[zookeeper-cleanup.timer].orig
  +++ Service[zookeeper-cleanup.timer]
  
  +    ensure   => running
  +    provider => systemd
  +    enable   => True
  

• Alternatives::Java[21]

  Parameters differences:

  --- Alternatives::Java[21].orig
  +++ Alternatives::Java[21]
  
  +    require => Java::Package[openjdk-jdk-21]
  

• File[/etc/zookeeper/conf/myid]

  Parameters differences:

  --- File[/etc/zookeeper/conf/myid].orig
  +++ File[/etc/zookeeper/conf/myid]
  
  +    group => root
  +    owner => root
  

  Content differences:

  --- /etc/zookeeper/conf/myid.orig
  +++ /etc/zookeeper/conf/myid
  @@ -0,0 +1 @@
  +2005

• Class[Zookeeper]

  Parameters differences:

  --- Class[Zookeeper].orig
  +++ Class[Zookeeper]
  
  +    sync_limit             => 8
  +    hosts                  => {'cloudcontrol2005-dev.codfw.wmnet': '2005', 'cloudcontrol2006-dev.codfw.wmnet': '2006', 'cloudcontrol2010-dev.codfw.wmnet': '2010'}
  +    before                 => ['Class[Zookeeper::Server]']
  +    data_dir               => /var/lib/zookeeper
  +    tick_time              => 2000
  +    max_client_connections => 1024
  +    conf_template          => profile/zookeeper/zoo.cfg.erb
  +    enable_tls             => False
  +    init_limit             => 10
  

• File[/etc/zookeeper/conf/log4j.properties]

  Parameters differences:

  --- File[/etc/zookeeper/conf/log4j.properties].orig
  +++ File[/etc/zookeeper/conf/log4j.properties]
  
  +    group   => root
  +    require => Package[zookeeperd]
  +    owner   => root
  

  Content differences:

  --- /etc/zookeeper/conf/log4j.properties.orig
  +++ /etc/zookeeper/conf/log4j.properties
  @@ -0,0 +1,31 @@
  +# Note: This file is managed by Puppet.
  +
  +#
  +# ZooKeeper Logging Configuration
  +#
  +
  +# Format is "<default threshold> (, <appender>)+
  +
  +log4j.rootLogger=${zookeeper.root.logger}, ROLLINGFILE
  +
  +#
  +# Log INFO level and above messages to the console
  +#
  +log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
  +log4j.appender.CONSOLE.Threshold=INFO
  +log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout
  +log4j.appender.CONSOLE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n
  +
  +#
  +# Add ROLLINGFILE to rootLogger to get log file output
  +#    Log INFO level and above messages to a log file
  +log4j.appender.ROLLINGFILE=org.apache.log4j.RollingFileAppender
  +log4j.appender.ROLLINGFILE.Threshold=INFO
  +log4j.appender.ROLLINGFILE.File=${zookeeper.log.dir}/zookeeper.log
  +
  +# Max log file size of 10MB
  +log4j.appender.ROLLINGFILE.MaxFileSize=10MB
  +# Keep only 10 files
  +log4j.appender.ROLLINGFILE.MaxBackupIndex=10
  +log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
  +log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n

• Package[prometheus-jmx-exporter]

  Parameters differences:

  --- Package[prometheus-jmx-exporter].orig
  +++ Package[prometheus-jmx-exporter]
  
  +    ensure   => installed
  +    provider => apt
  

• Class[Profile::Java]

  Parameters differences:

  --- Class[Profile::Java].orig
  +++ Class[Profile::Java]
  
  +    hardened_tls    => False
  +    java_packages   => []
  +    extra_args      => {}
  +    enable_dbg      => False
  +    egd_source      => /dev/random
  +    trust_puppet_ca => True
  

• File[/etc/zookeeper/conf/zoo.cfg]

  Parameters differences:

  --- File[/etc/zookeeper/conf/zoo.cfg].orig
  +++ File[/etc/zookeeper/conf/zoo.cfg]
  
  +    group   => root
  +    require => Package[zookeeper]
  +    owner   => root
  

  Content differences:

  --- /etc/zookeeper/conf/zoo.cfg.orig
  +++ /etc/zookeeper/conf/zoo.cfg
  @@ -0,0 +1,65 @@
  +# Note: This file is managed by Puppet.
  +
  +# http://hadoop.apache.org/zookeeper/docs/current/zookeeperAdmin.html
  +
  +# https://zookeeper.apache.org/doc/r3.4.10/zookeeperAdmin.html#sc_zkCommands
  +# T365400 Really we should check zk version >= 3.4.10 but for now just check os
  +4lw.commands.whitelist=*
  +
  +# specify all zookeeper servers
  +# The first port is used by followers to connect to the leader
  +# The second one is used for leader election
  +server.2005=cloudcontrol2005-dev.codfw.wmnet:2182:2183
  +server.2006=cloudcontrol2006-dev.codfw.wmnet:2182:2183
  +server.2010=cloudcontrol2010-dev.codfw.wmnet:2182:2183
  +
  +# the port at which the clients will connect
  +clientPort=2181
  +
  +# the directory where the snapshot is stored.
  +dataDir=/var/lib/zookeeper
  +
  +# Place the dataLogDir to a separate physical disc for better performance
  +# dataLogDir=/disk2/zookeeper
  +
  +
  +# The maximum number of connections per IP, 0 == unlimited
  +maxClientCnxns=1024
  +
  +# The number of milliseconds of each tick.
  +tickTime=2000
  +
  +# The number of ticks that the initial
  +# synchronization phase can take.
  +initLimit=10
  +
  +# The number of ticks that can pass between
  +# sending a request and getting an acknowledgement
  +syncLimit=8
  +
  +# To avoid seeks ZooKeeper allocates space in the transaction log file in
  +# blocks of preAllocSize kilobytes. The default block size is 64M. One reason
  +# for changing the size of the blocks is to reduce the block size if snapshots
  +# are taken more often. (Also, see snapCount).
  +#preAllocSize=65536
  +
  +# Clients can submit requests faster than ZooKeeper can process them,
  +# especially if there are a lot of clients. To prevent ZooKeeper from running
  +# out of memory due to queued requests, ZooKeeper will throttle clients so that
  +# there is no more than globalOutstandingLimit outstanding requests in the
  +# system. The default limit is 1,000.ZooKeeper logs transactions to a
  +# transaction log. After snapCount transactions are written to a log file a
  +# snapshot is started and a new transaction log file is started. The default
  +# snapCount is 10,000.
  +#snapCount=1000
  +
  +# If this option is defined, requests will be will logged to a trace file named
  +# traceFile.year.month.day.
  +#traceFile=
  +
  +# Leader accepts client connections. Default value is "yes". The leader machine
  +# coordinates updates. For higher update throughput at thes slight expense of
  +# read throughput the leader can be configured to not accept clients and focus
  +# on coordination.
  +#leaderServes=yes
  +

• File[/etc/logrotate.d/zookeeper-cleanup]

  Parameters differences:

  --- File[/etc/logrotate.d/zookeeper-cleanup].orig
  +++ File[/etc/logrotate.d/zookeeper-cleanup]
  
  +    mode   => 0444
  +    ensure => present
  +    group  => root
  +    owner  => root
  

  Content differences:

  --- /etc/logrotate.d/zookeeper-cleanup.orig
  +++ /etc/logrotate.d/zookeeper-cleanup
  @@ -0,0 +1,12 @@
  +# logrotate(8) config for zookeeper-cleanup
  +
  +/var/log/zookeeper-cleanup/*.log {
  +    daily
  +    copytruncate
  +    missingok
  +    compress
  +    delaycompress
  +    notifempty
  +    rotate 15
  +    size 256M
  +}

• Systemd::Timer[zookeeper-cleanup]

  Parameters differences:

  --- Systemd::Timer[zookeeper-cleanup].orig
  +++ Systemd::Timer[zookeeper-cleanup]
  
  +    timer_intervals    => [{'start': 'OnCalendar', 'interval': '*-*-* 0:10:00'}]
  +    splay              => 0
  +    unit_name          => zookeeper-cleanup.service
  +    fixed_random_delay => False
  +    ensure             => present
  +    accuracy           => 15sec
  

• Java::Package[openjdk-jdk-21]

  Parameters differences:

  --- Java::Package[openjdk-jdk-21].orig
  +++ Java::Package[openjdk-jdk-21]
  
  +    hardened_tls => False
  +    egd_source   => /dev/random
  +    package_info => {'version': '21', 'variant': 'jdk'}
  

• Class[Profile::Zookeeper::Firewall]

  Parameters differences:

  --- Class[Profile::Zookeeper::Firewall].orig
  +++ Class[Profile::Zookeeper::Firewall]
  
  +    firewall_access => ['cloudcontrol2005-dev.private.codfw.wikimedia.cloud', 'cloudcontrol2006-dev.private.codfw.wikimedia.cloud', 'cloudcontrol2010-dev.private.codfw.wikimedia.cloud']
  

• File[/lib/systemd/system/zookeeper-cleanup.timer]

  Parameters differences:

  --- File[/lib/systemd/system/zookeeper-cleanup.timer].orig
  +++ File[/lib/systemd/system/zookeeper-cleanup.timer]
  
  +    owner  => root
  +    ensure => present
  +    group  => root
  +    mode   => 0444
  +    notify => Exec[systemd daemon-reload for zookeeper-cleanup.timer (zookeeper-cleanup.timer)]
  

  Content differences:

  --- /lib/systemd/system/zookeeper-cleanup.timer.orig
  +++ /lib/systemd/system/zookeeper-cleanup.timer
  @@ -0,0 +1,12 @@
  +[Unit]
  +Description=Periodic execution of zookeeper-cleanup.service
  +
  +[Timer]
  +Unit=zookeeper-cleanup.service
  +# Accuracy sets the maximum time interval around the execution time we want to allow
  +AccuracySec=15sec
  +OnCalendar=*-*-* 0:10:00
  +RandomizedDelaySec=0
  +
  +[Install]
  +WantedBy=multi-user.target

• Exec[systemd daemon-reload for zookeeper-cleanup.service (zookeeper-cleanup.service)]

  Parameters differences:

  --- Exec[systemd daemon-reload for zookeeper-cleanup.service (zookeeper-cleanup.service)].orig
  +++ Exec[systemd daemon-reload for zookeeper-cleanup.service (zookeeper-cleanup.service)]
  
  +    refreshonly => True
  +    command     => /bin/systemctl daemon-reload
  

• Class[Java]

  Parameters differences:

  --- Class[Java].orig
  +++ Class[Java]
  
  +    hardened_tls  => False
  +    before        => ['Java::Cacert[wmf:puppetca.pem]', 'Java::Cacert[wmf:Wikimedia_Internal_Root_CA]', 'Java::Cacert[wmf:puppetca.pem]', 'Java::Cacert[wmf:Wikimedia_Internal_Root_CA]']
  +    require       => Package[wmf-certificates]
  +    java_packages => [{'version': '21', 'variant': 'jdk'}]
  +    enable_dbg    => False
  +    egd_source    => /dev/random
  

• Package[zookeeper]

  Parameters differences:

  --- Package[zookeeper].orig
  +++ Package[zookeeper]
  
  +    ensure   => installed
  +    provider => apt
  

• Ferm::Service[zookeeper]

  Parameters differences:

  --- Ferm::Service[zookeeper].orig
  +++ Ferm::Service[zookeeper]
  
  +    desc     => 
  +    proto    => tcp
  +    notrack  => False
  +    ensure   => present
  +    port     => [2181, 2182, 2183]
  +    src_sets => ['cloudcontrol2005-dev.private.codfw.wikimedia.cloud', 'cloudcontrol2006-dev.private.codfw.wikimedia.cloud', 'cloudcontrol2010-dev.private.codfw.wikimedia.cloud']
  +    prio     => 10
  

• Package[zookeeperd]

  Parameters differences:

  --- Package[zookeeperd].orig
  +++ Package[zookeeperd]
  
  +    ensure   => installed
  +    provider => apt
  

• Exec[update_java_alternatives_21]

  Parameters differences:

  --- Exec[update_java_alternatives_21].orig
  +++ Exec[update_java_alternatives_21]
  
  +    command => /usr/sbin/update-java-alternatives -s /usr/lib/jvm/java-1.21.0-openjdk-amd64
  +    unless  => /usr/bin/update-alternatives --query java | /bin/grep 'Value: /usr/lib/jvm/java-21-openjdk-amd64'
  

• Exec[systemd daemon-reload for zookeeper-cleanup.timer (zookeeper-cleanup.timer)]

  Parameters differences:

  --- Exec[systemd daemon-reload for zookeeper-cleanup.timer (zookeeper-cleanup.timer)].orig
  +++ Exec[systemd daemon-reload for zookeeper-cleanup.timer (zookeeper-cleanup.timer)]
  
  +    before      => ['Service[zookeeper-cleanup.timer]']
  +    refreshonly => True
  +    command     => /bin/systemctl daemon-reload
  

• Logrotate::Conf[zookeeper-cleanup]

  Parameters differences:

  --- Logrotate::Conf[zookeeper-cleanup].orig
  +++ Logrotate::Conf[zookeeper-cleanup]
  
  +    ensure => present
  

• Class[Profile::Openstack::Codfw1dev::Designate::Service]

  Parameters differences:

  --- Class[Profile::Openstack::Codfw1dev::Designate::Service].orig
  +++ Class[Profile::Openstack::Codfw1dev::Designate::Service]
  
  +    zookeeper_clusters => {'designate_eqiad1': {'hosts': {'cloudcontrol2005-dev.codfw.wmnet': '2005', 'cloudcontrol2006-dev.codfw.wmnet': '2006', 'cloudcontrol2010-dev.codfw.wmnet': '2010'}}}
  

• File[/var/log/zookeeper-cleanup]

  Parameters differences:

  --- File[/var/log/zookeeper-cleanup].orig
  +++ File[/var/log/zookeeper-cleanup]
  
  +    backup => False
  +    owner  => zookeeper
  +    force  => True
  +    ensure => directory
  +    group  => root
  +    mode   => 0755
  

• Java::Cacert[wmf:Wikimedia_Internal_Root_CA]

  Parameters differences:

  --- Java::Cacert[wmf:Wikimedia_Internal_Root_CA].orig
  +++ Java::Cacert[wmf:Wikimedia_Internal_Root_CA]
  
  +    storepass => changeit
  +    owner     => root
  +    require   => Alternatives::Java[21]
  +    ensure    => present
  +    group     => root
  +    path      => /usr/share/ca-certificates/wikimedia/Wikimedia_Internal_Root_CA.crt
  

• Service[zookeeper]

  Parameters differences:

  --- Service[zookeeper].orig
  +++ Service[zookeeper]
  
  +    ensure     => running
  +    hasrestart => True
  +    require    => ['Package[zookeeperd]', 'File[/var/lib/zookeeper]', 'File[/var/lib/zookeeper/myid]', 'File[/etc/default/zookeeper]', 'File[/etc/zookeeper/conf/zoo.cfg]', 'File[/etc/zookeeper/conf/myid]', 'File[/etc/zookeeper/conf/log4j.properties]']
  +    hasstatus  => True
  

• Systemd::Unit[zookeeper-cleanup.service]

  Parameters differences:

  --- Systemd::Unit[zookeeper-cleanup.service].orig
  +++ Systemd::Unit[zookeeper-cleanup.service]
  
  +    unit              => zookeeper-cleanup.service
  +    require           => ['Class[Systemd]']
  +    restart           => False
  +    override          => False
  +    ensure            => present
  +    override_filename => puppet-override.conf
  

• Class[Adduser]

  Parameters differences:

  --- Class[Adduser].orig
  +++ Class[Adduser]
  
  @@
  -    before => ['Package[puppet]', 'Package[facter]', 'Package[augeas-tools]', 'Package[virt-what]', 'Package[puppet-module-puppetlabs-augeas-core]', 'Package[python3-prometheus-client]', 'Package[python3-yaml]', 'Package[ruby-net-ssh]', 'Package[openssl]', 'Package[ssl-cert]', 'Package[ca-certificates]', 'Package[wmf-certificates]', 'Package[ntp]', 'Package[systemd-timesyncd]', 'Package[exim4-config]', 'Package[exim4-daemon-light]', 'Package[logrotate]', 'Package[prometheus-node-exporter]', 'Package[bsdutils]', 'Package[smartmontools]', 'Package[rsyslog]', 'Package[rsyslog-openssl]', 'Package[cadvisor]', 'Package[acct]', 'Package[byobu]', 'Package[colordiff]', 'Package[curl]', 'Package[debian-goodies]', 'Package[ethtool]', 'Package[gdb]', 'Package[gdisk]', 'Package[git]', 'Package[htop]', 'Package[httpry]', 'Package[iotop]', 'Package[iperf]', 'Package[jq]', 'Package[libtemplate-perl]', 'Package[lldpd]', 'Package[lshw]', 'Package[molly-guard]', 'Package[moreutils]', 'Package[net-tools]', 'Package[numactl]', 'Package[ncdu]', 'Package[ngrep]', 'Package[pigz]', 'Package[psmisc]', 'Package[pv]', 'Package[python3]', 'Package[screen]', 'Package[strace]', 'Package[sysstat]', 'Package[tcpdump]', 'Package[tmux]', 'Package[tree]', 'Package[vim]', 'Package[vim-addon-manager]', 'Package[vim-scripts]', 'Package[wipe]', 'Package[xfsprogs]', 'Package[zsh]', 'Package[icdiff]', 'Package[linux-perf]', 'Package[bsd-mailx]', 'Package[ack]', 'Package[netcat-openbsd]', 'Package[tshark]', 'Package[fzf]', 'Package[ripgrep]', 'Package[fd-find]', 'Package[kitty-terminfo]', 'Package[mtr-tiny]', 'Package[bat]', 'Package[efibootmgr]', 'Package[bind9-dnsutils]', 'Package[tzdata]', 'Package[python3-wmflib]', 'Package[starship]', 'Package[ruby-sorted-set]', 'Package[btop]', 'Package[linux-sysctl-defaults]', 'Package[apport]', 'Package[command-not-found]', 'Package[command-not-found-data]', 'Package[ecryptfs-utils]', 'Package[mlocate]', 'Package[os-prober]', 'Package[python3-apport]', 'Package[wpasupplicant]', 'Package[atop]', 'Package[apt-listchanges]', 'Package[isc-dhcp-client]', 'Package[rasdaemon]', 'Package[openssh-client]', 'Package[openssh-server]', 'Package[debdeploy-client]', 'Package[python3-dateutil]', 'Package[sudo]', 'Package[golang-cfssl]', 'Package[debmonitor-client]', 'Package[perccli]', 'Package[nagios-nrpe-server]', 'Package[monitoring-plugins]', 'Package[monitoring-plugins-basic]', 'Package[monitoring-plugins-standard]', 'Package[liburiparser1]', 'Package[python3-attr]', 'Package[iucode-tool]', 'Package[freeipmi-tools]', 'Package[freeipmi-ipmiseld]', 'Package[rsyslog-kafka]', 'Package[emacs-nox]', 'Package[prometheus-ipmi-exporter]', 'Package[libnet-dns-perl]', 'Package[iptables]', 'Package[ferm]', 'Package[ulogd2]', 'Package[conntrack]', 'Package[libapache2-mod-auth-openidc]', 'Package[apache2]', 'Package[links]', 'Package[keystone]', 'Package[alembic]', 'Package[ldapvi]', 'Package[python3-ldappool]', 'Package[python3-ldap3]', 'Package[ruby-net-ldap]', 'Package[python3-mwclient]', 'Package[libvirt-clients]', 'Package[python3-pytest]', 'Package[glance]', 'Package[placement-api]', 'Package[cinder-api]', 'Package[cinder-scheduler]', 'Package[cinder-volume]', 'Package[tgt]', 'Package[python3-trove]', 'Package[trove-common]', 'Package[trove-api]', 'Package[trove-taskmanager]', 'Package[trove-conductor]', 'Package[python3-sqlalchemy]', 'Package[designate-sink]', 'Package[designate-common]', 'Package[designate-mdns]', 'Package[designate]', 'Package[designate-api]', 'Package[designate-doc]', 'Package[designate-central]', 'Package[python3-git]', 'Package[mcrouter]', 'Package[radosgw]', 'Package[ceph-common]', 'Package[fio]', 'Package[heat-api]', 'Package[heat-api-cfn]', 'Package[heat-engine]', 'Package[magnum-api]', 'Package[magnum-conductor]', 'Package[python3-magnum-capi-helm]', 'Package[helm3]', 'Package[unzip]', 'Package[bridge-utils]', 'Package[nova-common]', 'Package[nova-conductor]', 'Package[nova-scheduler]', 'Package[nova-api]', 'Package[neutron-common]', 'Package[python3-novaclient]', 'Package[python3-glanceclient]', 'Package[python3-keystoneauth1]', 'Package[python3-keystoneclient]', 'Package[python3-openstackclient]', 'Package[python3-troveclient]', 'Package[python3-designateclient]', 'Package[python3-neutronclient]', 'Package[python3-osc-placement]', 'Package[python3-tenacity]', 'Package[patch]', 'Package[neutron-api]', 'Package[neutron-server]', 'Package[octavia-api]', 'Package[octavia-health-manager]', 'Package[octavia-housekeeping]', 'Package[octavia-worker]', 'Package[python3-octavia]', 'Package[python3-octaviaclient]', 'Package[ldap-utils]', 'Package[memcached]', 'Package[liburi-perl]', 'Package[mariadb-server]', 'Package[mariadb-backup]', 'Package[galera-4]', 'Package[barbican-api]', 'Package[ruby-concurrent]', 'Package[ruby]', 'Package[libruby]', 'Package[puppet-agent]', 'Package[prometheus-rsyslog-exporter]', 'Package[initramfs-tools]', 'Package[python3-click]', 'Package[python3-box]', 'Package[confd]', 'Package[python3-toml]', 'Package[vlan]', 'Package[prometheus-openstack-exporter]', 'Package[rsync]', 'Package[prometheus-memcached-exporter]', 'Package[tofu]', 'Package[prometheus-mysqld-exporter]', 'Package[bacula-fd]', 'Package[bacula-common]']
  +    before => ['Package[puppet]', 'Package[facter]', 'Package[augeas-tools]', 'Package[virt-what]', 'Package[puppet-module-puppetlabs-augeas-core]', 'Package[python3-prometheus-client]', 'Package[python3-yaml]', 'Package[ruby-net-ssh]', 'Package[openssl]', 'Package[ssl-cert]', 'Package[ca-certificates]', 'Package[wmf-certificates]', 'Package[ntp]', 'Package[systemd-timesyncd]', 'Package[exim4-config]', 'Package[exim4-daemon-light]', 'Package[logrotate]', 'Package[prometheus-node-exporter]', 'Package[bsdutils]', 'Package[smartmontools]', 'Package[rsyslog]', 'Package[rsyslog-openssl]', 'Package[cadvisor]', 'Package[acct]', 'Package[byobu]', 'Package[colordiff]', 'Package[curl]', 'Package[debian-goodies]', 'Package[ethtool]', 'Package[gdb]', 'Package[gdisk]', 'Package[git]', 'Package[htop]', 'Package[httpry]', 'Package[iotop]', 'Package[iperf]', 'Package[jq]', 'Package[libtemplate-perl]', 'Package[lldpd]', 'Package[lshw]', 'Package[molly-guard]', 'Package[moreutils]', 'Package[net-tools]', 'Package[numactl]', 'Package[ncdu]', 'Package[ngrep]', 'Package[pigz]', 'Package[psmisc]', 'Package[pv]', 'Package[python3]', 'Package[screen]', 'Package[strace]', 'Package[sysstat]', 'Package[tcpdump]', 'Package[tmux]', 'Package[tree]', 'Package[vim]', 'Package[vim-addon-manager]', 'Package[vim-scripts]', 'Package[wipe]', 'Package[xfsprogs]', 'Package[zsh]', 'Package[icdiff]', 'Package[linux-perf]', 'Package[bsd-mailx]', 'Package[ack]', 'Package[netcat-openbsd]', 'Package[tshark]', 'Package[fzf]', 'Package[ripgrep]', 'Package[fd-find]', 'Package[kitty-terminfo]', 'Package[mtr-tiny]', 'Package[bat]', 'Package[efibootmgr]', 'Package[bind9-dnsutils]', 'Package[tzdata]', 'Package[python3-wmflib]', 'Package[starship]', 'Package[ruby-sorted-set]', 'Package[btop]', 'Package[linux-sysctl-defaults]', 'Package[apport]', 'Package[command-not-found]', 'Package[command-not-found-data]', 'Package[ecryptfs-utils]', 'Package[mlocate]', 'Package[os-prober]', 'Package[python3-apport]', 'Package[wpasupplicant]', 'Package[atop]', 'Package[apt-listchanges]', 'Package[isc-dhcp-client]', 'Package[rasdaemon]', 'Package[openssh-client]', 'Package[openssh-server]', 'Package[debdeploy-client]', 'Package[python3-dateutil]', 'Package[sudo]', 'Package[golang-cfssl]', 'Package[debmonitor-client]', 'Package[perccli]', 'Package[nagios-nrpe-server]', 'Package[monitoring-plugins]', 'Package[monitoring-plugins-basic]', 'Package[monitoring-plugins-standard]', 'Package[liburiparser1]', 'Package[python3-attr]', 'Package[iucode-tool]', 'Package[freeipmi-tools]', 'Package[freeipmi-ipmiseld]', 'Package[rsyslog-kafka]', 'Package[emacs-nox]', 'Package[prometheus-ipmi-exporter]', 'Package[libnet-dns-perl]', 'Package[iptables]', 'Package[ferm]', 'Package[ulogd2]', 'Package[conntrack]', 'Package[libapache2-mod-auth-openidc]', 'Package[apache2]', 'Package[links]', 'Package[keystone]', 'Package[alembic]', 'Package[ldapvi]', 'Package[python3-ldappool]', 'Package[python3-ldap3]', 'Package[ruby-net-ldap]', 'Package[python3-mwclient]', 'Package[libvirt-clients]', 'Package[python3-pytest]', 'Package[glance]', 'Package[placement-api]', 'Package[cinder-api]', 'Package[cinder-scheduler]', 'Package[cinder-volume]', 'Package[tgt]', 'Package[python3-trove]', 'Package[trove-common]', 'Package[trove-api]', 'Package[trove-taskmanager]', 'Package[trove-conductor]', 'Package[python3-sqlalchemy]', 'Package[designate-sink]', 'Package[designate-common]', 'Package[designate-mdns]', 'Package[designate]', 'Package[designate-api]', 'Package[designate-doc]', 'Package[designate-central]', 'Package[python3-git]', 'Package[mcrouter]', 'Package[zookeeper]', 'Package[zookeeperd]', 'Package[radosgw]', 'Package[ceph-common]', 'Package[fio]', 'Package[heat-api]', 'Package[heat-api-cfn]', 'Package[heat-engine]', 'Package[magnum-api]', 'Package[magnum-conductor]', 'Package[python3-magnum-capi-helm]', 'Package[helm3]', 'Package[unzip]', 'Package[bridge-utils]', 'Package[nova-common]', 'Package[nova-conductor]', 'Package[nova-scheduler]', 'Package[nova-api]', 'Package[neutron-common]', 'Package[python3-novaclient]', 'Package[python3-glanceclient]', 'Package[python3-keystoneauth1]', 'Package[python3-keystoneclient]', 'Package[python3-openstackclient]', 'Package[python3-troveclient]', 'Package[python3-designateclient]', 'Package[python3-neutronclient]', 'Package[python3-osc-placement]', 'Package[python3-tenacity]', 'Package[patch]', 'Package[neutron-api]', 'Package[neutron-server]', 'Package[octavia-api]', 'Package[octavia-health-manager]', 'Package[octavia-housekeeping]', 'Package[octavia-worker]', 'Package[python3-octavia]', 'Package[python3-octaviaclient]', 'Package[ldap-utils]', 'Package[memcached]', 'Package[liburi-perl]', 'Package[mariadb-server]', 'Package[mariadb-backup]', 'Package[galera-4]', 'Package[barbican-api]', 'Package[ruby-concurrent]', 'Package[ruby]', 'Package[libruby]', 'Package[puppet-agent]', 'Package[prometheus-rsyslog-exporter]', 'Package[initramfs-tools]', 'Package[python3-click]', 'Package[python3-box]', 'Package[confd]', 'Package[python3-toml]', 'Package[vlan]', 'Package[prometheus-openstack-exporter]', 'Package[rsync]', 'Package[prometheus-jmx-exporter]', 'Package[openjdk-21-jdk]', 'Package[prometheus-memcached-exporter]', 'Package[tofu]', 'Package[prometheus-mysqld-exporter]', 'Package[bacula-fd]', 'Package[bacula-common]']
  

• File[/etc/rsyslog.d/40-zookeeper-cleanup.conf]

  Parameters differences:

  --- File[/etc/rsyslog.d/40-zookeeper-cleanup.conf].orig
  +++ File[/etc/rsyslog.d/40-zookeeper-cleanup.conf]
  
  +    owner  => root
  +    ensure => present
  +    group  => root
  +    mode   => 0444
  +    notify => Service[rsyslog]
  

  Content differences:

  --- /etc/rsyslog.d/40-zookeeper-cleanup.conf.orig
  +++ /etc/rsyslog.d/40-zookeeper-cleanup.conf
  @@ -0,0 +1,10 @@
  +# rsyslog.conf(5) configuration file for services.
  +# This file is managed by Puppet.
  +if $programname startswith "zookeeper-cleanup" then {
  +    action(
  +        type="omfile" file="/var/log/zookeeper-cleanup/syslog.log"
  +        fileOwner="zookeeper" fileGroup="root"
  +        fileCreateMode="0644"
  +    )
  +    & stop
  +}

• Java::Cacert[wmf:puppetca.pem]

  Parameters differences:

  --- Java::Cacert[wmf:puppetca.pem].orig
  +++ Java::Cacert[wmf:puppetca.pem]
  
  +    storepass => changeit
  +    owner     => root
  +    require   => Alternatives::Java[21]
  +    ensure    => present
  +    group     => root
  +    path      => /etc/ssl/certs/Puppet_Internal_CA.pem
  

• Class[Profile::Zookeeper::Server]

  Parameters differences:

  --- Class[Profile::Zookeeper::Server].orig
  +++ Class[Profile::Zookeeper::Server]
  
  +    sync_limit               => 8
  +    clusters                 => {'designate_eqiad1': {'hosts': {'cloudcontrol2005-dev.codfw.wmnet': '2005', 'cloudcontrol2006-dev.codfw.wmnet': '2006', 'cloudcontrol2010-dev.codfw.wmnet': '2010'}}}
  +    cluster_name             => designate_eqiad1
  +    require                  => ['Class[Profile::Java]', 'Class[Profile::Zookeeper::Monitoring::Server]']
  +    is_critical              => False
  +    monitoring_contact_group => admins
  +    prometheus_instance      => ops
  +    max_client_connections   => 1024
  +    enable_tls               => False
  +    monitoring_enabled       => False
  

• File[/etc/ferm/conf.d/10_zookeeper]

  Parameters differences:

  --- File[/etc/ferm/conf.d/10_zookeeper].orig
  +++ File[/etc/ferm/conf.d/10_zookeeper]
  
  +    tag     => ferm
  +    owner   => root
  +    require => File[/etc/ferm/conf.d]
  +    ensure  => present
  +    group   => root
  +    mode    => 0400
  +    notify  => Service[ferm]
  

  Content differences:

  --- /etc/ferm/conf.d/10_zookeeper.orig
  +++ /etc/ferm/conf.d/10_zookeeper
  @@ -0,0 +1,6 @@
  +# Autogenerated by puppet. DO NOT EDIT BY HAND!
  +#
  +# 
  +&R_SERVICE(tcp, (2181 2182 2183), ($cloudcontrol2005-dev.private.codfw.wikimedia.cloud $cloudcontrol2006-dev.private.codfw.wikimedia.cloud $cloudcontrol2010-dev.private.codfw.wikimedia.cloud));
  +
  +

• Systemd::Syslog[zookeeper-cleanup]

  Parameters differences:

  --- Systemd::Syslog[zookeeper-cleanup].orig
  +++ Systemd::Syslog[zookeeper-cleanup]
  
  +    log_filename           => syslog.log
  +    base_dir               => /var/log
  +    group                  => root
  +    readable_by            => all
  +    force_stop             => True
  +    ensure                 => present
  +    programname_comparison => startswith
  +    owner                  => zookeeper
  

• Systemd::Service[zookeeper-cleanup]

  Parameters differences:

  --- Systemd::Service[zookeeper-cleanup].orig
  +++ Systemd::Service[zookeeper-cleanup]
  
  +    migration_task           => T407130
  +    require                  => Systemd::Unit[zookeeper-cleanup.service]
  +    restart                  => False
  +    monitoring_critical      => False
  +    monitoring_contact_group => admins
  +    override                 => False
  +    unit_type                => timer
  +    service_params           => {}
  +    ensure                   => present
  +    monitoring_enabled       => False
  

• Exec[java__cacert_wmf:puppetca.pem]

  Parameters differences:

  --- Exec[java__cacert_wmf:puppetca.pem].orig
  +++ Exec[java__cacert_wmf:puppetca.pem]
  
  +    group   => root
  +    command => /usr/bin/keytool -import -trustcacerts -noprompt -cacerts     -file /etc/ssl/certs/Puppet_Internal_CA.pem -storepass changeit -alias wmf:puppetca.pem
  
  +    user    => root
  +    unless  => /usr/bin/keytool -list -cacerts -noprompt -storepass changeit -alias wmf:puppetca.pem
  

• File[/lib/systemd/system/zookeeper-cleanup.service]

  Parameters differences:

  --- File[/lib/systemd/system/zookeeper-cleanup.service].orig
  +++ File[/lib/systemd/system/zookeeper-cleanup.service]
  
  +    owner  => root
  +    ensure => present
  +    group  => root
  +    mode   => 0444
  +    notify => Exec[systemd daemon-reload for zookeeper-cleanup.service (zookeeper-cleanup.service)]
  

  Content differences:

  --- /lib/systemd/system/zookeeper-cleanup.service.orig
  +++ /lib/systemd/system/zookeeper-cleanup.service
  @@ -0,0 +1,8 @@
  +[Unit]
  +Description=Regular jobs for running the cleanup script
  +Documentation=https://wikitech.wikimedia.org/wiki/Monitoring/systemd_unit_state
  +
  +[Service]
  +Type=oneshot
  +User=zookeeper
  +ExecStart=/usr/share/zookeeper/bin/zkCleanup.sh -n 10

• Prometheus::Jmx_exporter_instance[zookeeper_server_cloudcontrol2005-dev]

  Parameters differences:

  --- Prometheus::Jmx_exporter_instance[zookeeper_server_cloudcontrol2005-dev].orig
  +++ Prometheus::Jmx_exporter_instance[zookeeper_server_cloudcontrol2005-dev]
  
  +    labels   => {'zookeeper_cluster': 'designate_eqiad1'}
  +    port     => 12181
  +    hostname => cloudcontrol2005-dev
  

• File[/var/lib/zookeeper]

  Parameters differences:

  --- File[/var/lib/zookeeper].orig
  +++ File[/var/lib/zookeeper]
  
  +    mode   => 0755
  +    ensure => directory
  +    group  => zookeeper
  +    owner  => zookeeper
  

• Class[Zookeeper::Server]

  Parameters differences:

  --- Class[Zookeeper::Server].orig
  +++ Class[Zookeeper::Server]
  
  +    log4j_template       => profile/zookeeper/log4j.properties.erb
  +    default_template     => profile/zookeeper/zookeeper.default.erb
  +    cleanup_timer_deploy => True
  +    java_opts            => -Xms1g -Xmx1g -javaagent:/usr/share/java/prometheus/jmx_prometheus_javaagent.jar=10.192.20.24:12181:/etc/prometheus/jvm_zookeeper_jmx_exporter.yaml
  +    jmx_port             => 9998
  +    cleanup_script       => /usr/share/zookeeper/bin/zkCleanup.sh
  +    cleanup_script_args  => -n 10
  +    java_home            => /usr/lib/jvm/java-21-openjdk-amd64
  +    enable_tls           => False
  

• Firewall::Service[zookeeper]

  Parameters differences:

  --- Firewall::Service[zookeeper].orig
  +++ Firewall::Service[zookeeper]
  
  +    desc     => 
  +    proto    => tcp
  +    notrack  => False
  +    ensure   => present
  +    port     => [2181, 2182, 2183]
  +    src_sets => ['cloudcontrol2005-dev.private.codfw.wikimedia.cloud', 'cloudcontrol2006-dev.private.codfw.wikimedia.cloud', 'cloudcontrol2010-dev.private.codfw.wikimedia.cloud']
  +    prio     => 10
  

• File[/etc/prometheus]

  Parameters differences:

  --- File[/etc/prometheus].orig
  +++ File[/etc/prometheus]
  
  +    ensure => directory
  +    group  => root
  +    owner  => root
  +    mode   => 0444
  

• Exec[openstack-flamingo-trixie-apt-upgrade]

  Parameters differences:

  --- Exec[openstack-flamingo-trixie-apt-upgrade].orig
  +++ Exec[openstack-flamingo-trixie-apt-upgrade]
  
  @@
  -    before => ['Package[puppet]', 'Package[facter]', 'Package[augeas-tools]', 'Package[virt-what]', 'Package[puppet-module-puppetlabs-augeas-core]', 'Package[python3-prometheus-client]', 'Package[python3-yaml]', 'Package[ruby-net-ssh]', 'Package[openssl]', 'Package[ssl-cert]', 'Package[ca-certificates]', 'Package[wmf-certificates]', 'Package[ntp]', 'Package[systemd-timesyncd]', 'Package[exim4-config]', 'Package[exim4-daemon-light]', 'Package[logrotate]', 'Package[prometheus-node-exporter]', 'Package[bsdutils]', 'Package[smartmontools]', 'Package[rsyslog]', 'Package[rsyslog-openssl]', 'Package[cadvisor]', 'Package[acct]', 'Package[byobu]', 'Package[colordiff]', 'Package[curl]', 'Package[debian-goodies]', 'Package[ethtool]', 'Package[gdb]', 'Package[gdisk]', 'Package[git]', 'Package[htop]', 'Package[httpry]', 'Package[iotop]', 'Package[iperf]', 'Package[jq]', 'Package[libtemplate-perl]', 'Package[lldpd]', 'Package[lshw]', 'Package[molly-guard]', 'Package[moreutils]', 'Package[net-tools]', 'Package[numactl]', 'Package[ncdu]', 'Package[ngrep]', 'Package[pigz]', 'Package[psmisc]', 'Package[pv]', 'Package[python3]', 'Package[screen]', 'Package[strace]', 'Package[sysstat]', 'Package[tcpdump]', 'Package[tmux]', 'Package[tree]', 'Package[vim]', 'Package[vim-addon-manager]', 'Package[vim-scripts]', 'Package[wipe]', 'Package[xfsprogs]', 'Package[zsh]', 'Package[icdiff]', 'Package[linux-perf]', 'Package[bsd-mailx]', 'Package[ack]', 'Package[netcat-openbsd]', 'Package[tshark]', 'Package[fzf]', 'Package[ripgrep]', 'Package[fd-find]', 'Package[kitty-terminfo]', 'Package[mtr-tiny]', 'Package[bat]', 'Package[efibootmgr]', 'Package[bind9-dnsutils]', 'Package[tzdata]', 'Package[python3-wmflib]', 'Package[starship]', 'Package[ruby-sorted-set]', 'Package[btop]', 'Package[linux-sysctl-defaults]', 'Package[apport]', 'Package[command-not-found]', 'Package[command-not-found-data]', 'Package[ecryptfs-utils]', 'Package[mlocate]', 'Package[os-prober]', 'Package[python3-apport]', 'Package[wpasupplicant]', 'Package[atop]', 'Package[apt-listchanges]', 'Package[isc-dhcp-client]', 'Package[rasdaemon]', 'Package[openssh-client]', 'Package[openssh-server]', 'Package[debdeploy-client]', 'Package[python3-dateutil]', 'Package[sudo]', 'Package[golang-cfssl]', 'Package[debmonitor-client]', 'Package[perccli]', 'Package[nagios-nrpe-server]', 'Package[monitoring-plugins]', 'Package[monitoring-plugins-basic]', 'Package[monitoring-plugins-standard]', 'Package[liburiparser1]', 'Package[python3-attr]', 'Package[iucode-tool]', 'Package[freeipmi-tools]', 'Package[freeipmi-ipmiseld]', 'Package[rsyslog-kafka]', 'Package[emacs-nox]', 'Package[prometheus-ipmi-exporter]', 'Package[libnet-dns-perl]', 'Package[iptables]', 'Package[ferm]', 'Package[ulogd2]', 'Package[conntrack]', 'Package[libapache2-mod-auth-openidc]', 'Package[apache2]', 'Package[links]', 'Package[keystone]', 'Package[alembic]', 'Package[ldapvi]', 'Package[python3-ldappool]', 'Package[python3-ldap3]', 'Package[ruby-net-ldap]', 'Package[python3-mwclient]', 'Package[libvirt-clients]', 'Package[python3-pytest]', 'Package[glance]', 'Package[placement-api]', 'Package[cinder-api]', 'Package[cinder-scheduler]', 'Package[cinder-volume]', 'Package[tgt]', 'Package[python3-trove]', 'Package[trove-common]', 'Package[trove-api]', 'Package[trove-taskmanager]', 'Package[trove-conductor]', 'Package[python3-sqlalchemy]', 'Package[designate-sink]', 'Package[designate-common]', 'Package[designate-mdns]', 'Package[designate]', 'Package[designate-api]', 'Package[designate-doc]', 'Package[designate-central]', 'Package[python3-git]', 'Package[mcrouter]', 'Package[radosgw]', 'Package[ceph-common]', 'Package[fio]', 'Package[heat-api]', 'Package[heat-api-cfn]', 'Package[heat-engine]', 'Package[magnum-api]', 'Package[magnum-conductor]', 'Package[python3-magnum-capi-helm]', 'Package[helm3]', 'Package[unzip]', 'Package[bridge-utils]', 'Package[nova-common]', 'Package[nova-conductor]', 'Package[nova-scheduler]', 'Package[nova-api]', 'Package[neutron-common]', 'Package[python3-novaclient]', 'Package[python3-glanceclient]', 'Package[python3-keystoneauth1]', 'Package[python3-keystoneclient]', 'Package[python3-openstackclient]', 'Package[python3-troveclient]', 'Package[python3-designateclient]', 'Package[python3-neutronclient]', 'Package[python3-osc-placement]', 'Package[python3-tenacity]', 'Package[patch]', 'Package[neutron-api]', 'Package[neutron-server]', 'Package[octavia-api]', 'Package[octavia-health-manager]', 'Package[octavia-housekeeping]', 'Package[octavia-worker]', 'Package[python3-octavia]', 'Package[python3-octaviaclient]', 'Package[ldap-utils]', 'Package[memcached]', 'Package[liburi-perl]', 'Package[mariadb-server]', 'Package[mariadb-backup]', 'Package[galera-4]', 'Package[barbican-api]', 'Package[ruby-concurrent]', 'Package[ruby]', 'Package[libruby]', 'Package[puppet-agent]', 'Package[prometheus-rsyslog-exporter]', 'Package[initramfs-tools]', 'Package[python3-click]', 'Package[python3-box]', 'Package[confd]', 'Package[python3-toml]', 'Package[vlan]', 'Package[prometheus-openstack-exporter]', 'Package[rsync]', 'Package[prometheus-memcached-exporter]', 'Package[tofu]', 'Package[prometheus-mysqld-exporter]', 'Package[bacula-fd]', 'Package[bacula-common]']
  +    before => ['Package[puppet]', 'Package[facter]', 'Package[augeas-tools]', 'Package[virt-what]', 'Package[puppet-module-puppetlabs-augeas-core]', 'Package[python3-prometheus-client]', 'Package[python3-yaml]', 'Package[ruby-net-ssh]', 'Package[openssl]', 'Package[ssl-cert]', 'Package[ca-certificates]', 'Package[wmf-certificates]', 'Package[ntp]', 'Package[systemd-timesyncd]', 'Package[exim4-config]', 'Package[exim4-daemon-light]', 'Package[logrotate]', 'Package[prometheus-node-exporter]', 'Package[bsdutils]', 'Package[smartmontools]', 'Package[rsyslog]', 'Package[rsyslog-openssl]', 'Package[cadvisor]', 'Package[acct]', 'Package[byobu]', 'Package[colordiff]', 'Package[curl]', 'Package[debian-goodies]', 'Package[ethtool]', 'Package[gdb]', 'Package[gdisk]', 'Package[git]', 'Package[htop]', 'Package[httpry]', 'Package[iotop]', 'Package[iperf]', 'Package[jq]', 'Package[libtemplate-perl]', 'Package[lldpd]', 'Package[lshw]', 'Package[molly-guard]', 'Package[moreutils]', 'Package[net-tools]', 'Package[numactl]', 'Package[ncdu]', 'Package[ngrep]', 'Package[pigz]', 'Package[psmisc]', 'Package[pv]', 'Package[python3]', 'Package[screen]', 'Package[strace]', 'Package[sysstat]', 'Package[tcpdump]', 'Package[tmux]', 'Package[tree]', 'Package[vim]', 'Package[vim-addon-manager]', 'Package[vim-scripts]', 'Package[wipe]', 'Package[xfsprogs]', 'Package[zsh]', 'Package[icdiff]', 'Package[linux-perf]', 'Package[bsd-mailx]', 'Package[ack]', 'Package[netcat-openbsd]', 'Package[tshark]', 'Package[fzf]', 'Package[ripgrep]', 'Package[fd-find]', 'Package[kitty-terminfo]', 'Package[mtr-tiny]', 'Package[bat]', 'Package[efibootmgr]', 'Package[bind9-dnsutils]', 'Package[tzdata]', 'Package[python3-wmflib]', 'Package[starship]', 'Package[ruby-sorted-set]', 'Package[btop]', 'Package[linux-sysctl-defaults]', 'Package[apport]', 'Package[command-not-found]', 'Package[command-not-found-data]', 'Package[ecryptfs-utils]', 'Package[mlocate]', 'Package[os-prober]', 'Package[python3-apport]', 'Package[wpasupplicant]', 'Package[atop]', 'Package[apt-listchanges]', 'Package[isc-dhcp-client]', 'Package[rasdaemon]', 'Package[openssh-client]', 'Package[openssh-server]', 'Package[debdeploy-client]', 'Package[python3-dateutil]', 'Package[sudo]', 'Package[golang-cfssl]', 'Package[debmonitor-client]', 'Package[perccli]', 'Package[nagios-nrpe-server]', 'Package[monitoring-plugins]', 'Package[monitoring-plugins-basic]', 'Package[monitoring-plugins-standard]', 'Package[liburiparser1]', 'Package[python3-attr]', 'Package[iucode-tool]', 'Package[freeipmi-tools]', 'Package[freeipmi-ipmiseld]', 'Package[rsyslog-kafka]', 'Package[emacs-nox]', 'Package[prometheus-ipmi-exporter]', 'Package[libnet-dns-perl]', 'Package[iptables]', 'Package[ferm]', 'Package[ulogd2]', 'Package[conntrack]', 'Package[libapache2-mod-auth-openidc]', 'Package[apache2]', 'Package[links]', 'Package[keystone]', 'Package[alembic]', 'Package[ldapvi]', 'Package[python3-ldappool]', 'Package[python3-ldap3]', 'Package[ruby-net-ldap]', 'Package[python3-mwclient]', 'Package[libvirt-clients]', 'Package[python3-pytest]', 'Package[glance]', 'Package[placement-api]', 'Package[cinder-api]', 'Package[cinder-scheduler]', 'Package[cinder-volume]', 'Package[tgt]', 'Package[python3-trove]', 'Package[trove-common]', 'Package[trove-api]', 'Package[trove-taskmanager]', 'Package[trove-conductor]', 'Package[python3-sqlalchemy]', 'Package[designate-sink]', 'Package[designate-common]', 'Package[designate-mdns]', 'Package[designate]', 'Package[designate-api]', 'Package[designate-doc]', 'Package[designate-central]', 'Package[python3-git]', 'Package[mcrouter]', 'Package[zookeeper]', 'Package[zookeeperd]', 'Package[radosgw]', 'Package[ceph-common]', 'Package[fio]', 'Package[heat-api]', 'Package[heat-api-cfn]', 'Package[heat-engine]', 'Package[magnum-api]', 'Package[magnum-conductor]', 'Package[python3-magnum-capi-helm]', 'Package[helm3]', 'Package[unzip]', 'Package[bridge-utils]', 'Package[nova-common]', 'Package[nova-conductor]', 'Package[nova-scheduler]', 'Package[nova-api]', 'Package[neutron-common]', 'Package[python3-novaclient]', 'Package[python3-glanceclient]', 'Package[python3-keystoneauth1]', 'Package[python3-keystoneclient]', 'Package[python3-openstackclient]', 'Package[python3-troveclient]', 'Package[python3-designateclient]', 'Package[python3-neutronclient]', 'Package[python3-osc-placement]', 'Package[python3-tenacity]', 'Package[patch]', 'Package[neutron-api]', 'Package[neutron-server]', 'Package[octavia-api]', 'Package[octavia-health-manager]', 'Package[octavia-housekeeping]', 'Package[octavia-worker]', 'Package[python3-octavia]', 'Package[python3-octaviaclient]', 'Package[ldap-utils]', 'Package[memcached]', 'Package[liburi-perl]', 'Package[mariadb-server]', 'Package[mariadb-backup]', 'Package[galera-4]', 'Package[barbican-api]', 'Package[ruby-concurrent]', 'Package[ruby]', 'Package[libruby]', 'Package[puppet-agent]', 'Package[prometheus-rsyslog-exporter]', 'Package[initramfs-tools]', 'Package[python3-click]', 'Package[python3-box]', 'Package[confd]', 'Package[python3-toml]', 'Package[vlan]', 'Package[prometheus-openstack-exporter]', 'Package[rsync]', 'Package[prometheus-jmx-exporter]', 'Package[openjdk-21-jdk]', 'Package[prometheus-memcached-exporter]', 'Package[tofu]', 'Package[prometheus-mysqld-exporter]', 'Package[bacula-fd]', 'Package[bacula-common]']
  

• Systemd::Unit[zookeeper-cleanup.timer]

  Parameters differences:

  --- Systemd::Unit[zookeeper-cleanup.timer].orig
  +++ Systemd::Unit[zookeeper-cleanup.timer]
  
  +    unit              => zookeeper-cleanup.timer
  +    require           => ['Class[Systemd]']
  +    restart           => False
  +    override          => False
  +    ensure            => present
  +    override_filename => puppet-override.conf
  

• Class[Profile::Zookeeper::Monitoring::Server]

  Parameters differences:

  --- Class[Profile::Zookeeper::Monitoring::Server].orig
  +++ Class[Profile::Zookeeper::Monitoring::Server]
  
  +    cluster_name => designate_eqiad1
  

Relevant files

• Production catalog
• Change catalog
• Production errors/warnings
• Change errors/warnings
• Core Diff
• Standard Diff